Fixed namespace and type errors, changed null to undefined where applicable#18345
Fixed namespace and type errors, changed null to undefined where applicable#18345karrtikr merged 7 commits intomicrosoft:mainfrom Harry-Hopkinson:main
Conversation
…nd fetches the path of the interpreter.
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for the PR. Please add a news entry thanking yourself (See news/README.md for instructions)
| @@ -0,0 +1 @@ | |||
| Fixed typescript and namespace errors. | |||
There was a problem hiding this comment.
| Fixed typescript and namespace errors. | |
| Fixed typescript and namespace errors. (thanks [Harry-Hopkinson](https://github.com/Harry-Hopkinson)) |
|
Please see the build run https://github.com/microsoft/vscode-python/runs/4947683364?check_suite_focus=true. It seems lint is failing, see the coding guidelines for contributing: https://github.com/microsoft/vscode-python/wiki/Coding#typescript where we ask to install prettier extension for typescript. |
Harry-Hopkinson
changed the title
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
You do not need to run prettier on every file, just the files that you changed. Please undo the last commit.
|
Okay I am trying to redo the last commit |
|
What command shall I run |
|
Install the Prettier extension, we already have it selected and format on save turned on: So just modifying and saving files should format them. |
|
Thanks |
|
It works - thank you very much |
|
Eslint still needs to be run on other files though, I can do that on another commit. |
|
Alright. Just leaving a comment tagging me (@karrtikr) when you're done. |
|
@karrtikr the errors for linting are happening on files that I have not worked on. Shall I format them? |
|
It seems you have modified https://github.com/microsoft/vscode-python/pull/18345/files#diff-4af161d784faa3a10fc0a2cc01cb14ab2dca2a161eea6e8e9944c2ee602af762 for which the error is happening. |
|
Ah yes - I have ran prettier on the file |
karrtikr
changed the title
|
Thanks! |
|
Some of the checks failed after the pull request. How come? |
|
That does not seem to be related to your PR. It seems it originated from https://github.com/microsoft/vscode-python/actions/runs/1748411413. |
|
Okay - so my PR pushed fine? |
|
Yes... |
|
Thanks - how do we stop these checks from failing? |
…icable (microsoft/vscode-python#18345) * Fixed namespace and type errors * Fetch Jupyter Notebook Interpreters if there are multiple available and fetches the path of the interpreter. * Complying types to reduce errors * Ran prettier * News * Used prettier on service.ts
2 participants
No description provided.