Native Editor - Startup jupyter server automatically in the background

[rchiodo]

Possibly make this an option

[IanMatthewHuff]

• Determine our method for when we will auto start a server. PM help here. Server run from this workspace before?
• Starting the server can just use our existing code
• When any settings that change our server cache key hit, chuck the server and start a new one.

[rchiodo]

I think we had talked about this before (the when to do this). I believe the agreed upon idea was:

• When opening a notebook (since they obviously are opening notebooks)
• When previously opened the interactive window (maybe based on since a certain time)
• If jupyter is installed in the current environment (and cells in a python file)

[IanMatthewHuff]

Yup, figured that it was still worth calling out that we should verify with PM these conditions. Didn't seem like that was a fully settled discussion from my memory.

[DonJayamanne]

See #2535 for details
Probably after #2693 (to avoid re-work due to changes from #2693)

[rchiodo]

This is blocked currently on #2693

[DonJayamanne]

@rchiodo @IanMatthewHuff
I thought I could do this. Looks like there are a few things I don't understand.
Will need a hand with this. Re-using servers, starting a server from outside a notebook (today the information required to start jupyter server comes from a notebook and this isn't public, its protected and used by interactive base).

I think the information required/used to start jupyter should be handled outside by a seprate class. If you agree, then we'll nee a way to move it out.
Lets discuss on monday.

[IanMatthewHuff]

So the basics are validated, tried with new workspaces with just a notebook and just the interactive window to make sure that initially it didn't autostart and that it did auto start after running.

@rchiodo I did notice that for the interactive windows it's firing every time that focus is going to the window, not just when it opens, should pretty much be a no-op so I don't really see an issue there, but was that intentional?

[rchiodo]

Not sure what you mean by this?

it's firing

What's firing?

[IanMatthewHuff]

onDidOpenOrCloseInteractive is happening every time focus goes out of the interactive window. So click over from the interactive window to a .py file and createServerIfNecessary runs. Seem ok, since it just updates the memento time. But given the OpenOrClose title I'm assuming this might not have been intentional.

[rchiodo]

Ah okay. That seems harmless for now. The custom editor API should fix that.

[IanMatthewHuff]

Sounds good. Then Validated.