Add command translation for Farsi/Persian#8092
Merged
karthiknadig merged 5 commits intomicrosoft:masterfrom Oct 26, 2019
Nikronic:master
Merged
Add command translation for Farsi/Persian#8092karthiknadig merged 5 commits intomicrosoft:masterfrom Nikronic:master
karthiknadig merged 5 commits intomicrosoft:masterfrom
Nikronic:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8092 +/- ##
==========================================
- Coverage 59.26% 58.57% -0.69%
==========================================
Files 499 505 +6
Lines 22411 24066 +1655
Branches 3598 4042 +444
==========================================
+ Hits 13281 14096 +815
- Misses 8301 9084 +783
- Partials 829 886 +57
Continue to review full report at Codecov.
|
Member
|
@Nikronic Thank you for the translation. For |
Author
|
@karthiknadig you right. Actually I was in a dilemma that I should follow English convention or Farsi community's. I will resolve it soon. |
karthiknadig
approved these changes
Oct 22, 2019
Co-Authored-By: Karthik Nadig <kanadig@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #7931
Appropriate comments and documentation strings in the codeHas sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.