Skip to content

feat: Add different views of Binary Tree#3428

Closed
sujay31 wants to merge 1 commit intoTheAlgorithms:masterfrom
sujay31:master
Closed

feat: Add different views of Binary Tree#3428
sujay31 wants to merge 1 commit intoTheAlgorithms:masterfrom
sujay31:master

Conversation

@sujay31
Copy link
Copy Markdown

@sujay31 sujay31 commented Oct 6, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.

@sujay31 sujay31 mentioned this pull request Oct 6, 2022
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please add some JUnit tests and remove main? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2023
@github-actions
Copy link
Copy Markdown

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants