Fixed problem where match string contain special characters#18878
Merged
Conversation
Closed
2 tasks
karrtikr
reviewed
Apr 7, 2022
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please add a news entry thanking yourself (see news/README.md for details).
karrtikr
reviewed
Apr 7, 2022
Added Credits.
|
|
karrtikr
reviewed
Apr 9, 2022
Simplify code. Co-authored-by: Kartik Raj <karraj@microsoft.com>
karrtikr
reviewed
Apr 11, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…t/vscode-python#18878) * Fixed problem where match string contain special characters * Fixes issue where () and | are escaped for windows * Fixed a problem when some characters are not escaped. Added Credits. * Update src/client/common/process/logger.ts Simplify code. Co-authored-by: Kartik Raj <karraj@microsoft.com> * Only replace '\\' with '(\\|/)' on Windows to save a scan on other OSs. * Update src/client/common/process/logger.ts Co-authored-by: Kartik Raj <karraj@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18829