feat: add PYTHON_DOTENV_DISABLED flag to disable load_dotenv (fixes #510)#569
Merged
theskumar merged 10 commits intotheskumar:mainfrom Jun 24, 2025
Merged
feat: add PYTHON_DOTENV_DISABLED flag to disable load_dotenv (fixes #510)#569theskumar merged 10 commits intotheskumar:mainfrom
PYTHON_DOTENV_DISABLED flag to disable load_dotenv (fixes #510)#569theskumar merged 10 commits intotheskumar:mainfrom
Conversation
This is something that could be debated so adding an explicit test for it is worthwhile
62e61fd to
e293438
Compare
theskumar
reviewed
Jun 24, 2025
e6c8eff to
c0d4772
Compare
theskumar
requested changes
Jun 24, 2025
Owner
theskumar
left a comment
There was a problem hiding this comment.
Minor suggestions, rest looks good to me.
Thank you for the quick iterations. ❤️
Co-authored-by: Saurabh Kumar <theskumar@users.noreply.github.com>
Co-authored-by: Saurabh Kumar <theskumar@users.noreply.github.com>
PYTHON_DOTENV_DISABLED flag to disable load_dotenv (fixes #510)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using approach proposed here.