Skip to content

Create Rotated_Binary_Search.java#3795

Closed
raman04-byte wants to merge 1 commit intoTheAlgorithms:masterfrom
raman04-byte:master
Closed

Create Rotated_Binary_Search.java#3795
raman04-byte wants to merge 1 commit intoTheAlgorithms:masterfrom
raman04-byte:master

Conversation

@raman04-byte
Copy link
Copy Markdown

Searching in the rotated Binary search

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

Searching in the rotated Binary search
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)

@raman04-byte
Copy link
Copy Markdown
Author

raman04-byte commented Dec 16, 2022 via email

return Binarysearch(nums, target, pivot+1, nums.length-1);
}

static int Binarysearch(int[] arr, int target, int start, int end) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name should follow camel case.'B' should be small.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A 's' should be capital.

@debasishbsws
Copy link
Copy Markdown
Member

I don't know how to add JUnit test

On Fri, Dec 16, 2022 at 3:15 PM Andrii Siriak @.> wrote: @.* requested changes on this pull request. The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms ) — Reply to this email directly, view it on GitHub <#3795 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASESLGTZEJ6RG3YXETUOJW3WNQ2Z3ANCNFSM6AAAAAATAELKDU . You are receiving this because you authored the thread.Message ID: @.***>

You can go to the provided link and take a look of other JUnit tests code, and make one for yours too. It was very simple you will get it.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 19, 2023
@github-actions
Copy link
Copy Markdown

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@github-actions github-actions bot closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants