chore: update README to include instructions on bazelisk installation#1271
chore: update README to include instructions on bazelisk installation#1271burkedavison merged 4 commits intomainfrom
Conversation
| Before running the integration tests, make sure to install bazelisk: | ||
|
|
||
| ```shell | ||
| $ go install github.com/bazelbuild/bazelisk@latest |
There was a problem hiding this comment.
Hm. I'm surprised you needed to explicitly install bazelisk -- I think it came with my bazel installation, or I'm forgetting the manual install...
There was a problem hiding this comment.
oh interesting! For me, it was still missing despite install bazel:
mpeddada@mpeddada:~/IdeaProjects/gapic-generator-java/showcase$ sudo apt-get install bazel
[sudo] password for mpeddada:
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
bazel is already the newest version (6.0.0).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
mpeddada@mpeddada:~/IdeaProjects/gapic-generator-java/showcase$ bazelisk
bash: bazelisk: command not found
There was a problem hiding this comment.
Ah. Yes. You are correct.
$ which bazelisk
/opt/homebrew/bin/bazelisk
$ brew list
==> Formulae
bazelisk [...]So at some point I invoked brew install bazelisk
There was a problem hiding this comment.
I think you do have to install bazelisk separately, I learned that the hard way.
Another nit, this would require us to install go as well, I know go is already required for showcase testing so this is easy for us to set up the environment, but do we want to add more info(e.g. bazelisk Github page) for what bazelisk is and how to set it up in case the go install does not work.
There was a problem hiding this comment.
@mpeddada1 Add a link to bazelisk installation documentation. I don't want readers relying on 'go'. (I use npm to use bazelisk.). Move that paragraph to "## Set Up" section.
There was a problem hiding this comment.
Done. Replaced the instruction with a link to the Github page and moved it to "Set Up". Thank you!
|
Kudos, SonarCloud Quality Gate passed!
|
4 participants
No description provided.