Skip to content

build: not relying on gax's zip archive#1273

Merged
gcf-merge-on-green[bot] merged 4 commits intomainfrom
remove_gax-java_ref
Jan 26, 2023
Merged

build: not relying on gax's zip archive#1273
gcf-merge-on-green[bot] merged 4 commits intomainfrom
remove_gax-java_ref

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Jan 25, 2023

gax-java is now part of gapic-generator-java. No need to fetch
the released zip file to get the dependencies list.

In future, we'll revisit how we maintain the dependencies to
the user of gapic-generator-java, even for self-service users.

gax-java is now part of gapic-generator-java. No need to fetch
the released zip file to get the dependencies list.

In future, we'll revisit how we maintain the dependencies to
the user of gapic-generator-java, even for self-service users.
@suztomo suztomo requested a review from a team January 25, 2023 18:59
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2023

Unclear error.

2023-01-25T19:07:41.5888110Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5888197Z [INFO] Reactor Summary:
2023-01-25T19:07:41.5888262Z [INFO] 
2023-01-25T19:07:41.5888507Z [INFO] GAPIC Showcase Client Core Parent 0.0.1-SNAPSHOT ... SUCCESS [  2.602 s]
2023-01-25T19:07:41.5888756Z [INFO] proto-gapic-showcase-v1beta1 0.0.1-SNAPSHOT ........ FAILURE [05:48 min]
2023-01-25T19:07:41.5888979Z [INFO] grpc-gapic-showcase-v1beta1 0.0.1-SNAPSHOT ......... SKIPPED
2023-01-25T19:07:41.5889176Z [INFO] GAPIC Showcase Client 0.0.1-SHAPSHOT ............... SKIPPED
2023-01-25T19:07:41.5889401Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5889482Z [INFO] BUILD FAILURE
2023-01-25T19:07:41.5889711Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5889800Z [INFO] Total time:  05:52 min
2023-01-25T19:07:41.5889962Z [INFO] Finished at: 2023-01-25T19:07:41Z
2023-01-25T19:07:41.5890184Z [INFO] ------------------------------------------------------------------------
2023-01-25T19:07:41.5890725Z [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:3.1.0:exec (verify-showcase) on project proto-gapic-showcase-v1beta1: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2023

SonarCloud failed:

Error:  Failures: 
Error:    BatcherImplTest.testThrottlingBlocking:897 
Wanted but not invoked:
apiCallContext.withOption(
    <Capturing argument>,
    <Capturing argument>
);
-> at com.google.api.gax.batching.BatcherImplTest.testThrottlingBlocking(BatcherImplTest.java:897)
Actually, there were zero interactions with this mock.

[INFO] 
Error:  Tests run: 529, Failures: 1, Errors: 0, Skipped: 0

Retrying.

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2023

~/gapic-generator-java $ bazel run //showcase:verify_grpc succeeded in my laptop. Strange. Trying //showcase:verify_proto.

@mpeddada1 @burkedavison The failure is unclear. In another pull request, would you separate golden test and integration tests?

Screenshot 2023-01-25 at 2 59 13 PM

Also, I felt it's very strange to call Maven, which calls Bazel, which calls verify.sh. Can this be more simplified? I'm looking for something like this:

bazel ... # generate code
verify.sh # verifies the code based on golden files

When it comes to GitHub Actions, steps like this below would clarify what is it failing.

- name: Generate showcase client code
  run: bazel ...
- name: Verify the generated code against golden files
  run: verify.sh

@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Jan 25, 2023

It turned out that the failure is about golden file. Not integration tests.

@suztomo suztomo requested a review from blakeli0 January 25, 2023 20:41
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gcf-merge-on-green gcf-merge-on-green Bot merged commit 86a560d into main Jan 26, 2023
@gcf-merge-on-green gcf-merge-on-green Bot deleted the remove_gax-java_ref branch January 26, 2023 17:50
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants