Skip to content

Fix failing multiroot test#24049

Merged
rchiodo merged 3 commits intomicrosoft:mainfrom
rchiodo:rchiodo/fix_ev_provider
Sep 4, 2024
Merged

Fix failing multiroot test#24049
rchiodo merged 3 commits intomicrosoft:mainfrom
rchiodo:rchiodo/fix_ev_provider

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Sep 3, 2024

Fixes #24046

Comment thread .vscode/launch.json Outdated
mockEnvironmentActivationService
.setup((m) => m.getActivatedEnvironmentVariables(anything()))
.returns(() => Promise.resolve({}));
if (ioc.serviceManager.tryGet<IEnvironmentActivationService>(IEnvironmentActivationService)) {
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause was inversify fails now if you rebind when something isn't already bound.

@rchiodo rchiodo added the no-changelog No news entry required label Sep 3, 2024
@rchiodo rchiodo requested a review from karthiknadig September 3, 2024 23:39
@rchiodo rchiodo self-assigned this Sep 3, 2024
@vs-code-engineering vs-code-engineering Bot added this to the September 2024 milestone Sep 3, 2024
@rchiodo rchiodo merged commit 3343560 into microsoft:main Sep 4, 2024
@rchiodo rchiodo deleted the rchiodo/fix_ev_provider branch September 4, 2024 16:27
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-testing no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing with Could not unbind serviceIdentifier

3 participants