Run PR activities on push on non-default branch

[ewjoachim]

Closes #234, Closes #246

Still needs:

• Manual tests
• A decision regarding whether we need e2e tests for that or not
• Documentation (especially on how to write the part that posts the comment from the artifact. Though it will be very much like CommentPR.yml from here)

But the code is written, and we already have 100% coverage so that's a good start.

[github-actions]

End-to-end public repo

[github-actions]

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

coverage_comment/activity.py

100% of new lines are covered (100% of the complete file).

coverage_comment/main.py

100% of new lines are covered (100% of the complete file).

coverage_comment/settings.py

100% of new lines are covered (100% of the complete file).

coverage_comment/github.py

100% of new lines are covered (100% of the complete file).

[kieferro]

Great, looks good 👍. I still have a few small comments, but I tested with a copy of the template repo and everything seems to work fine.

[ewjoachim]

Comments addressed. For the question of the default branch, I've:

• removed previous coverage data when running on a PR not targeting the default branch
• but kept it in case we're running on a branch with no PR yet: we can't know.

[ewjoachim]

I've also changed the Note that displays where there's no reference coverage info to use a specific message in the case it's because the PR doesn't target the default branch

[kieferro]

Looks great 👍

A decision regarding whether we need e2e tests for that or not

I'm not quite sure if this is so easy to test if we also want to test the normal use cases and therefore want to keep pull_request as a trigger. We could build some system that this trigger is ignored for example if the PR title contains a certain word and we create a PR which contains that word and tests if it also works only through the push trigger, but I don't know if that's worth the effort. What's your assessment?

[ewjoachim]

What's your assessment?

I agree with you :)