debugpy: Fetch a wheel into Zed's work dir and use that with users venv#35640
debugpy: Fetch a wheel into Zed's work dir and use that with users venv#35640
Conversation
cla-bot
bot
added
the
cla-signed
|
Thanks for keeping at it—it’s working! Though there is windows platform related issue that Because it's called |
|
No, thank you for the continuous feedback of high quality. :) I don't have a Windows box (I can fetch the windows wheels just fine though). I wonder how VSC's extension handles that on Windows though 🤔 This is the code that sets the expected name to "attach.dll": https://github.com/microsoft/debugpy/blob/1aff9aa541955b967f41895570d4c0b54a7504d9/src/debugpy/_vendored/pydevd/pydevd_tracing.py#L254 |
|
In their bundled plugin, they use |
|
It seems like this was ~broken by microsoft/debugpy#1917. In such case, are you okay with me merging this PR as-is and then following up by fixing that upstream in debugpy itself? |
|
Ok fine😂 There's not much that can be done for that. Thank you. VS Code releases its DAP through a plugin, whereas Zed bundles it directly. You really do a great job. |
|
Yeah, we'll just need them to bump the debugpy version - we don't need to wait for a new plugin version |
Follow-up to microsoft#1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)
|
@Sansui233 just to confirm - which Python version are you using? Apparently it's only broken in 3.11 and below (per linked PR). |
Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment)
…nv (zed-industries#35640) Another stab at zed-industries#35388 cc @Sansui233 Closes zed-industries#35388 Release Notes: - debugger: Fixed Python debug sessions failing to launch due to a missing debugpy installation.
…nv (zed-industries#35640) Another stab at zed-industries#35388 cc @Sansui233 Closes zed-industries#35388 Release Notes: - debugger: Fixed Python debug sessions failing to launch due to a missing debugpy installation.
* pydevd: Fix up prefix of attach shared library for Windows (#1939) Follow-up to #1917, which changed the prefix for Windows. The crux of that contribution was about enabling attaching on Sillicon Mac (in fact, it came from my colleagues at Zed Industries). This however broke .dll lookup per zed-industries/zed#35640 (comment) * Check if `os.__file__` is available before using it (#1944) * check if os.file is available before using it * use threading.__file__ als last fallback * update testing for python 3.14 (#1955) * update testing for python 3.14 * Allow python 3.14 in attach code * move 3.14 to its own job outside of matrix * try 3.14.0-rc.2 * allowUnstable * use 3.14.0-rc.2 but use 3.14 in tests * include py.typed in the distributed package (#1960) * Add gcc flags (#1947) * Add pyrx-admins as code owners (#1976) * Add pyrx-admins as code owners * Combine CODEOWNERS entries into a single line --------- Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com> Co-authored-by: timrid <6593626+timrid@users.noreply.github.com> Co-authored-by: Bill Schnurr <bschnurr@hotmail.com> Co-authored-by: lev-blit <47675736+lev-blit@users.noreply.github.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
2 participants
Another stab at #35388
cc @Sansui233
Closes #35388
Release Notes: